[Issue #15] fix trino query execution issues in flink mode#19
[Issue #15] fix trino query execution issues in flink mode#19gengdy1545 wants to merge 1 commit intoAntiO2:masterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8875c19b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| SchemaTableName schemaTableName = new SchemaTableName(request.getSchemaName(), request.getTableName()); | ||
| LOGGER.debug("Received poll request for table '{}'", schemaTableName); | ||
| FreshnessClient.getInstance().addMonitoredTable(request.getTableName()); |
There was a problem hiding this comment.
Only embed mode starts and drains FreshnessClient (PixelsSinkApp calls freshnessClient.start() only when sink.monitor.freshness.level == "embed"), but this new unconditional call runs for every Flink poll request. In row/txn modes it still initializes the singleton and keeps adding table names to monitoredTables even though no scheduler cycle runs to clear them, which can accumulate state unnecessarily and can surface config-time failures from FreshnessClient in modes that should not depend on Trino settings.
Useful? React with 👍 / 👎.
1 participant
No description provided.